clayborg added a comment. LGTM. Probably should get one more ok
================ Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91 + size_t BlobAllocator::allocateString(StringRef Str) { SmallVector<UTF16, 32> WStr; ---------------- Might be nice to unique the strings in here? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60405/new/ https://reviews.llvm.org/D60405 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits