clayborg marked 2 inline comments as done.
clayborg added inline comments.
================
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:160
+ self.verify_module(modules[0],
+ "libuuidmatch.so",
+ "7295E17C-6668-9E05-CBB5-DEE5003865D5-5267C116")
----------------
labath wrote:
> The second failure I had was due to the full module showing up when the
> module was found, so this check failed.
>
> The interesting part (and the reason why I checked out this patch) was that
> the module was still being found even when I removed the
> `basename_module_spec.GetFileSpec().GetDirectory().Clear();` line, which was
> my last uncertainty about this patch. So now I even more strongly believe
> that the clearing of the directory file spec is unnecessary and should be
> removed.
And that _didn't_ work for me. If I removed it, it doesn't work on macOS. I
wonder if we might be setting some image search paths up as part of the test. I
just tested manually and if I do the command in a fresh LLDB, I get the
fullpath, even on mac. If I run through the test suite, then I just get the
basename???
================
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:176
+ so_path = self.getBuildArtifact("libuuidmismatch.so")
+ self.yaml2obj("libuuidmatch.yaml", so_path)
+ self.dbg.CreateTarget(None)
----------------
labath wrote:
> I think this is one of the causes of failure. Changing this to
> libuuidmismatch.yaml made it work for me.
Ok, I will fix this.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60001/new/
https://reviews.llvm.org/D60001
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
