labath added inline comments.
================
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:160
+ self.verify_module(modules[0],
+ "libuuidmatch.so",
+ "7295E17C-6668-9E05-CBB5-DEE5003865D5-5267C116")
----------------
The second failure I had was due to the full module showing up when the module
was found, so this check failed.
The interesting part (and the reason why I checked out this patch) was that the
module was still being found even when I removed the
`basename_module_spec.GetFileSpec().GetDirectory().Clear();` line, which was my
last uncertainty about this patch. So now I even more strongly believe that the
clearing of the directory file spec is unnecessary and should be removed.
================
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:176
+ so_path = self.getBuildArtifact("libuuidmismatch.so")
+ self.yaml2obj("libuuidmatch.yaml", so_path)
+ self.dbg.CreateTarget(None)
----------------
I think this is one of the causes of failure. Changing this to
libuuidmismatch.yaml made it work for me.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60001/new/
https://reviews.llvm.org/D60001
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
