jingham accepted this revision. jingham added a comment. Except for a typo and a little quibble about a comment, this looks okay to me.
================ Comment at: source/Plugins/ExpressionParser/Clang/ClangHost.cpp:42 /// This will compute the clang resource directory assuming that clang was -/// installed with the same prefix as lldb. +/// installed with the same prefix as lldb. Note: the verify paramter is +/// currently only used for testing. ---------------- spelling: parameter But also, you should say something more informative, like: If verify is true, the first candidate resource directory will be returned. This mode is only used for testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59708/new/ https://reviews.llvm.org/D59708 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
