xiaobai added a comment.

I changed the default behavior here setting file_spec to some known default 
unverified value to not setting it at all. It previously relied on there being 
a relative path to the clang resource dir, of which there are now two to pick 
from. Additionally, we pass in the directory containing liblldb to 
ComputeClangResourceDirectory now. The default behavior of 
`HostInfo::ComputePathRelativeToLibrary` was just computing it again and 
munging paths without verifying it. I think that if we fail to find the clang 
resource directory, the logs here should be sufficient to get started debugging.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59708/new/

https://reviews.llvm.org/D59708



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to