balazske added inline comments.
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:583
+ // Returns a ImporterConstructor that constructs this class.
+ static ASTImporterOptionSpecificTestBase::ImporterConstructor
+ getConstructor() {
----------------
balazske wrote:
> Is it possible to make this a static variable instead of function?
Another small thing: The comment above is now not updated ("Returns").
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:348
+
+ void setImporter(std::unique_ptr<ASTImporter> I) {
+ Importer = std::move(I);
----------------
This function is not needed?
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:482
+ ASTImporter &getImporter(Decl *From, Language ToLang) {
+ lazyInitToAST(ToLang, "", OutputFileName);
----------------
This is unused, can be removed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59485/new/
https://reviews.llvm.org/D59485
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
