balazske added a comment. It looks better now. One "problem" is that now there is the strategy and there is the `Imported` function. It would be possible to unify these into a strategy that contains maybe a "import" and a "post-import" callback. (But this requires big changes in the `ASTImporter` user code.)
================ Comment at: clang/include/clang/AST/ASTImporter.h:154 + /// The Shim that should rewrite the import calls of this ASTImporter, or + /// a nullptr of this ASTImporter has no shim. ---------------- 'Shim' should be replaced with 'strategy' (and the nullptr means "no user-specified strategy" or "default strategy"). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits