aprantl added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:89 } llvm_unreachable("invalid UnitType."); } ---------------- Not your code, but this application of `llvm_unreachable` seems suspicious unless we can guarantee that we already checked for a supported format before entering here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59235/new/ https://reviews.llvm.org/D59235 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits