zturner marked an inline comment as done. zturner added a comment. It seems like we're mostly in agreement on the direction of the patch, so if there's no outstanding comments I'll submit at the end of the day.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263 uint64_t length = data.GetU32(&offset); - bool isDwarf64 = (length == 0xffffffff); - if (isDwarf64) ---------------- jankratochvil wrote: > Here should be an error that DWARF64 is not supported. How do we report that error? This function doesn't return an error code, and neither does the function that calls it (I didn't look higher than that), and we don't build with exceptions. We can assert, but we try to avoid asserts (although admittedly, we're going to crash anyway). I can try to do more work to propagate errors up the stack, but at this point this whole file (and even most of the folder that the file is in) is in theory going to be going away soon as we converge on LLVM's DWARF parser, so it may make sense to just deal with the problem at that level. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59235/new/ https://reviews.llvm.org/D59235 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
