davide added a comment. Just a drive-by comment. I think writing this as a inline test would make it more compact (and maybe slightly more readable because you don't have to look at two files), but if you prefer this way, I don't have a strong preference.
================ Comment at: packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py:3 +They may be cases where an expression will import SourceLocation and if the +SoureLocation ends up with a FileID that is a built-in we need to copy that +buffer over correctly. ---------------- minor, `SourceLocation`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58790/new/ https://reviews.llvm.org/D58790 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
