aprantl added inline comments.

================
Comment at: 
packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py:17
+
+    @skipUnlessDarwin
+    @add_test_categories(["gmodules"])
----------------
The Cocoa framework only exists on macOS, there's a skipDarwinEmbedded (or 
similar) decorator that you can use to skip the test on iOS. Alternatively, if 
the problem also reproduces by including CoreGraphics alone, that one I believe 
exists everywhere.


================
Comment at: 
packages/Python/lldbsuite/test/expression_command/import_builtin_fileid/TestImportBuiltinFileID.py:18
+    @skipUnlessDarwin
+    @add_test_categories(["gmodules"])
+    def test_import_builtin_fileid(self):
----------------
do you mean: skip unless gmodules?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58790/new/

https://reviews.llvm.org/D58790



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to