labath added a reviewer: clayborg.
labath added a comment.

I think this basically defeats the purpose of the `IsUnspecifiedUnknown` 
functions, which was to differentiate between foo-unknown-bar and foo--bar 
triples. That in itself was a pretty big hack, but it seems that there is 
functionality which depends on this. There was a discussion about this back in 
december http://lists.llvm.org/pipermail/lldb-dev/2018-December/014437.html, 
and IIRC it converged to some sort of a conclusion, but I don't think there 
hasn't been any effort to try to implement it. I'm not sure what exactly it 
means about the future of this patch, but I'd be cautious about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58653/new/

https://reviews.llvm.org/D58653



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to