xiaobai added a comment. In D58653#1409978 <https://reviews.llvm.org/D58653#1409978>, @JDevlieghere wrote:
> Do we actually need to check the string values in addition to the enum > values? It looks like the llvm class tries pretty hard to make that the > canonical way to query it. I know triples and arches are pretty tricky in > lldb though, so maybe there's a reason that we can't. I wasn't sure when I was writing this, but I just tried and the tests seem to pass when we just check the enum values so I presume it's fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58653/new/ https://reviews.llvm.org/D58653 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
