shafik added a comment.
Looks like a great fix!
================
Comment at: MIDataTypes.h:67
+template <typename T>
+class MIDereferenceable {
+public:
----------------
Can we use `llvm::Optional` instead? Then we can use `getValueOr()`.
================
Comment at: MIDataTypes.h:71
+
+ T *Or(T &alt_value) { return m_ptr ? m_ptr : &alt_value; }
+private:
----------------
If we can not use `llvm::Optional` then why not just take `T *`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55653/new/
https://reviews.llvm.org/D55653
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
