clayborg added inline comments.
================
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:87-97
// The textual module id encoding should be between 33 and 40 bytes long,
// depending on the size of the age field, which is of variable length.
// The first three chunks of the id are encoded in big endian, so we need to
// byte-swap those.
- if (str.size() < 33 || str.size() > 40)
+ if (str.size() <= hex_digits<data_t::uuid_t>() ||
+ str.size() > hex_digits<data_t>())
return UUID();
----------------
This is OK as long as the UUIDs for ELF don't fall into this category. I am
able to match up UUIDs for ELF just fine for breakpad files for Android.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57037/new/
https://reviews.llvm.org/D57037
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
