Hui added a comment.


> - drop the `if (m_entries[i].quote)` branch. You don't need it here, and I 
> don't believe it will be correct anyway, because all it will do is cause 
> `llvm::sys::flattenWindowsCommandLine` to add one more quote level around 
> that and escape the quotes added by yourself

The quote char might be specified through Args::AppendArgument at user's will.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56230/new/

https://reviews.llvm.org/D56230



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to