shafik added a comment. Are we refactoring in the right place? Why not just refactor `FileSpec::GetByteSize()` why is `FileSpec` the wrong place?
================ Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:718 + (FileSystem::Instance().GetByteSize(file) - file_offset) / + 1024); ---------------- `1024u` just for consistency, I don't expect this is practically a problem. Repository: rLLDB LLDB https://reviews.llvm.org/D53788 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits