jankratochvil added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:312
void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) {
+ m_die_array.clear();
----------------
labath wrote:
> You are ignoring the keep_compile_unit_die argument here. Is that
> intentional? (I would be fine with not being able to clear the unit die, but
> if we got that way, then we should remove this argument altogether.)
I did not notice, true. But there is no caller of `ClearDIEs(false)` anyway.
And with `m_first_die` it has even no longer any benefit to clear even the
first DIE.
https://reviews.llvm.org/D46810
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
