jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:86
// Keep a flat array of the DIE for binary lookup by DIE offset
- if (!cu_die_only) {
+ {
Log *log(
----------------
clayborg wrote:
> Do we need this empty scope? Remove?
There is now enclosed:
```Log *log(LogChannelDWARF::GetLogIfAny(DWARF_LOG_DEBUG_INFO |
DWARF_LOG_LOOKUPS));
```
While lower (currently moved into `DWARFUnit::ExtractDIEsEndCheck()`) there was:
```Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO));
```
So those two did conflict while being a different variable. I am not sure which
way is right but I have removed the empty scope as it is no longer required.
Then also I am not sure the log in `DWARFUnit::ExtractDIEsEndCheck()` should
not also have `| DWARF_LOG_LOOKUPS` but that would be out of the scope of this
patch topic.
https://reviews.llvm.org/D46810
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
