clayborg added a comment.
Looks fine. Just one question on keeping the DWARFIndex::Create() functions so
they all have the same signature.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:40
+
+std::unique_ptr<AppleIndex> AppleIndex::Create(
+ Module &module, DWARFDataExtractor apple_names,
----------------
Move all AppleIndex stuff to a dedicated .cpp file?
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:321
+
+void ManualIndex::Index() {
+ if (!m_debug_info)
----------------
Move all ManualIndex stuff to a dedicated .cpp file?
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.h:71
+
+class AppleIndex : public DWARFIndex {
+public:
----------------
Rename to AppleDWARFIndex and move to AppleDWARFIndex.h?
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.h:127
+
+class ManualIndex : public DWARFIndex {
+public:
----------------
Rename to ManualDWARFIndex and move to ManualDWARFIndex.h?
https://reviews.llvm.org/D46889
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
