labath added inline comments.

================
Comment at: source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp:1037
     SetError(set, Write, -1);
-    return KERN_INVALID_ARGUMENT;
+    return -1;
   }
----------------
aprantl wrote:
> Could we keep this as a local constant?
> perhaps with an #ifndef KERN_INVALID_ARGUMENT clause?
We could. I didn't do that originally, as 
`RegisterContextDarwin_x86_64::WriteGPR()` looks exactly like this function, 
and it uses `-1` already, but that works for me as well.


https://reviews.llvm.org/D46934



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to