beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This all looks fine to me. The one thing I'd like you to consider is that
someday (when lldb-server is supported on Darwin) we will want to run these
tests against both debugserver and lldb-server. I'm not asking you to make
those changes to this patch, but if there are things you would change about how
you're doing things to make that easier to support I'd ask that you consider
that.
I have one specific comment below that is along those lines. Otherwise, this
LGTM.
================
Comment at: unittests/tools/lldb-server/tests/TestClient.cpp:32
+bool TestClient::IsDebugServer() {
+#ifdef __APPLE__
+ return true;
----------------
Instead of making this ifdef'd can you just check to see if `LLDB_SERVER` is
debugserver or lldb-server?
One of the items on my todo list is to get rid of all the places where `#ifdef
__APPLE__` equates to using debugserver so that we can start evaluating making
lldb-server work on Darwin.
https://reviews.llvm.org/D35311
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
