jingham added a comment.

This isn't about this patch, but replying to:

> debugserver replies to the k packet instead of just dropping the connection - 
> stopping code adjusted, although we should probably consider aligning the 
> behavior of the two stubs in this case

Especially when dealing with flakey connections, knowing that you are done with 
a target was really handy.  People what to hit "rerun" in some UI and have the 
rerun happen instantly, but if you have no way of knowing when the former 
process actually died, you have to introduce delays, which slows this down.  
This is particularly true when talking to an OS that really wants only one copy 
of an "app" running at a time (e.g. iOS) but is more generally useful for 
responsiveness.  And if something goes wrong with killing the target, we could 
even use the new error reply strings to give more info about this.


https://reviews.llvm.org/D35311



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to