zturner added inline comments.
================ Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:98 + unsigned int register_id; + key_str_ref.getAsInteger(10, register_id); + ---------------- Do you need to check for an error here? ================ Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:105 + unsigned int register_value; + value_str_ref.getAsInteger(16, register_value); + registers[register_id] = register_value; ---------------- And here https://reviews.llvm.org/D32930 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
