takuto.ikuta added inline comments.
================
Comment at: unittests/CMakeLists.txt:57
add_subdirectory(Breakpoint)
+add_subdirectory(tools)
add_subdirectory(Core)
----------------
better to sort alphabetically?
Using tools instead of Tools intentionally?
================
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:6
+
+using namespace std;
+
----------------
Need to remove this?
================
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:133
+
+ for (auto i = elements.begin(); i != elements.end(); i++) {
+ if (i->first[0] == 'T' && i->first.substr(3, 6) == "thread") {
----------------
Why not range based for?
https://reviews.llvm.org/D32930
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
