ravitheja marked 2 inline comments as done. ravitheja added a comment. In https://reviews.llvm.org/D32585#740632, @labath wrote:
> I quite like that you have added just the packet plumbing code without an > concrete implementation. However, that is still a significant amount of > parsing code that should be accompanied by a test. The test suite for the > client side of the protocol is ready (TestGdbRemoteCommunicationClient), so > I'd like to see at least that. @labath I was considering writing Unit tests for the remote packets but I thought then I have to write the mock implementation for the trace operations as well, which might end up being a bigger piece of code than the actual packet parsing code. After this patch, I will upload the actual server side code doing the trace stuff for linux, that part of code has unit tests for some core functions. https://reviews.llvm.org/D32585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
