DavidSpickett wrote:
The following change caused 371 tests to fail on Linux, so I think there are
callers of this function and this is not NFC.
```
$ git diff
diff --git a/lldb/include/lldb/Host/posix/HostThreadPosix.h
b/lldb/include/lldb/Host/posix/HostThreadPosix.h
index 6c8e09fc1103..1462fdbbfbda 100644
--- a/lldb/include/lldb/Host/posix/HostThreadPosix.h
+++ b/lldb/include/lldb/Host/posix/HostThreadPosix.h
@@ -25,6 +25,8 @@ public:
Status Join(lldb::thread_result_t *result) override;
Status Cancel() override;
+ void Reset() override;
+
Status Detach();
};
diff --git a/lldb/source/Host/posix/HostThreadPosix.cpp
b/lldb/source/Host/posix/HostThreadPosix.cpp
index a53a8cc9d838..32f672abaa1b 100644
--- a/lldb/source/Host/posix/HostThreadPosix.cpp
+++ b/lldb/source/Host/posix/HostThreadPosix.cpp
@@ -59,3 +59,7 @@ Status HostThreadPosix::Detach() {
Reset();
return error;
}
+
+void HostThreadPosix::Reset() {
+ __builtin_trap();
+}
```
Which is not a problem in itself, just proving a point that this PR needs to be
correctly described.
https://github.com/llvm/llvm-project/pull/179470
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
