DavidSpickett wrote:

Looks good to me, but -

Is this going to also solve the lldb-server problem you observed, or do you 
have a follow up PR to do that?

If this PR will solve that problem, either:
* Open an issue for it and tag this as solving it, or
* Include a brief version of your diagnosis from the other issue, at the end of 
this PR's description

Perfectly fine to justify this change as being cleaner and more correct, I 
agree with that. Just don't want to lose track of the motivating problem in 
case it comes back or others are looking for existing fixes for it.

https://github.com/llvm/llvm-project/pull/179470
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to