Author: Michael Buch Date: 2026-01-19T11:20:27Z New Revision: 9c75d2739499805d9e3e23fb308463d317487571
URL: https://github.com/llvm/llvm-project/commit/9c75d2739499805d9e3e23fb308463d317487571 DIFF: https://github.com/llvm/llvm-project/commit/9c75d2739499805d9e3e23fb308463d317487571.diff LOG: [lldb][DWARFASTParserClang][NFC] Remove obsolete DEBUG_PRINTF Uncommenting `ENABLE_DEBUG_PRINTF` wasn't compiling on top-of-tree. This code may have been useful for debugging locally in the past but it doesn't seem compelling to keep this in the source-tree. Especially because it doesn't compile, indicating it's most likely not used. This patch removes `DEBUG_PRINTF` entirely. Added: Modified: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp index d65aa40b5be86..d7a7f44622c68 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -56,15 +56,6 @@ #include <optional> #include <vector> -//#define ENABLE_DEBUG_PRINTF // COMMENT OUT THIS LINE PRIOR TO CHECKIN - -#ifdef ENABLE_DEBUG_PRINTF -#include <cstdio> -#define DEBUG_PRINTF(fmt, ...) printf(fmt, __VA_ARGS__) -#else -#define DEBUG_PRINTF(fmt, ...) -#endif - using namespace lldb; using namespace lldb_private; using namespace lldb_private::plugin::dwarf; @@ -797,10 +788,6 @@ DWARFASTParserClang::ParseTypeModifier(const SymbolContext &sc, } } - DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\") type => 0x%8.8lx\n", die.GetID(), - DW_TAG_value_to_name(tag), type_name_cstr, - encoding_uid.Reference()); - switch (tag) { default: break; @@ -1325,9 +1312,6 @@ DWARFASTParserClang::ParseSubroutine(const DWARFDIE &die, bool is_variadic = false; bool has_template_params = false; - DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\")\n", die.GetID(), - DW_TAG_value_to_name(tag), type_name_cstr); - CompilerType return_clang_type; Type *func_type = nullptr; @@ -1498,9 +1482,6 @@ DWARFASTParserClang::ParseArrayType(const DWARFDIE &die, const ParsedDWARFTypeAttributes &attrs) { SymbolFileDWARF *dwarf = die.GetDWARF(); - DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\")\n", die.GetID(), - DW_TAG_value_to_name(tag), type_name_cstr); - DWARFDIE type_die = attrs.type.Reference(); Type *element_type = dwarf->ResolveTypeUID(type_die, true); @@ -1812,9 +1793,6 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, } } - DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\")\n", die.GetID(), - DW_TAG_value_to_name(tag), type_name_cstr); - int tag_decl_kind = -1; AccessType default_accessibility = eAccessNone; if (tag == DW_TAG_structure_type) { _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
