Author: Ebuka Ezike Date: 2026-01-19T11:09:41Z New Revision: c61d5f9814ea5f88a43dfe5fae7cb79798ac0c5d
URL: https://github.com/llvm/llvm-project/commit/c61d5f9814ea5f88a43dfe5fae7cb79798ac0c5d DIFF: https://github.com/llvm/llvm-project/commit/c61d5f9814ea5f88a43dfe5fae7cb79798ac0c5d.diff LOG: [lldb-dap][NFC] Address comments grammar. (#176233) From https://github.com/llvm/llvm-project/pull/175930#pullrequestreview-3667183086 Added: Modified: lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp lldb/tools/lldb-dap/Protocol/ProtocolRequests.h lldb/unittests/DAP/ProtocolTypesTest.cpp Removed: ################################################################################ diff --git a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp index 23789f6d46f90..a72802a33fc9c 100644 --- a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp +++ b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp @@ -335,7 +335,6 @@ bool fromJSON(const llvm::json::Value &Params, DAPSession &Ses, llvm::json::Path P) { json::ObjectMapper O(Params, P); - // Validate that both debuggerID and targetId are provided. return O && O.map("targetId", Ses.targetId) && O.map("debuggerId", Ses.debuggerId); } diff --git a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h index 9d5bdf1efe94c..471484e1ba356 100644 --- a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h +++ b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h @@ -318,10 +318,10 @@ using LaunchResponse = VoidResponse; #define LLDB_DAP_INVALID_FRAME_ID UINT64_MAX struct DAPSession { - /// Unique ID of an existing target to attach to. + /// A unique ID of an existing target to attach to. lldb::user_id_t targetId; - /// ID of an existing debugger instance to use. + /// A unique ID of an existing debugger instance to use. lldb::user_id_t debuggerId; }; bool fromJSON(const llvm::json::Value &, DAPSession &, llvm::json::Path); @@ -360,7 +360,7 @@ struct AttachRequestArguments { /// Path to the core file to debug. std::string coreFile; - /// An Existing session that consist of a target and debugger. + /// An existing session that consist of a target and debugger. std::optional<DAPSession> session; /// @} diff --git a/lldb/unittests/DAP/ProtocolTypesTest.cpp b/lldb/unittests/DAP/ProtocolTypesTest.cpp index 6476492813455..82753d3fe0cfd 100644 --- a/lldb/unittests/DAP/ProtocolTypesTest.cpp +++ b/lldb/unittests/DAP/ProtocolTypesTest.cpp @@ -1264,7 +1264,7 @@ TEST(ProtocolTypesTest, StackFrame) { } TEST(ProtocolTypesTest, DAPSession) { - const DAPSession session{/*targetId*/ 1000, /*debuggerId*/ 300}; + const DAPSession session{/*targetId=*/1000, /*debuggerId=*/300}; auto expected = parse<DAPSession>(R"({"targetId": 1000, "debuggerId": 300})"); ASSERT_THAT_EXPECTED(expected, llvm::Succeeded()); _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
