eugene marked 3 inline comments as done. eugene added a comment. Addressing review comments.
================ Comment at: unittests/Signals/UnixSignalsTest.cpp:43 + +#define ASSERT_EQ_ARRAYS(expected, observed) \ + AssertEqArrays((expected), (observed), __FILE__, __LINE__); ---------------- labath wrote: > This (and the function) should probably have an EXPECT_.. prefix instead, as > it does not abort the evaluation of the function it is in (like other > ASSERT_*** macros). This function calls ASSERT_EQ so it does abort evaluation. https://reviews.llvm.org/D30520 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
