clayborg added a comment.

My main objection is that if we have 10 "lldb_private::Process::Will*" 
functions and only some require you to call the superclass, then it is 
confusing. It is also hard to enforce. We probably have other process 
subclasses that override these functions and they all would be broken. It also 
makes it harder when merging code to other branches that might have an extra 
process subclass. The merge would go fine, but any process subclasses that 
exist only in other branches would now be out of date and doing the wrong thing 
by not calling the superclass.


https://reviews.llvm.org/D30520



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to