royitaqi wrote:
@JDevlieghere: Thank you for your reply. I appreciate it a lot.
I will:
1. Learn about the memory monitor in DAP.
* Context: It's not failing - We are just starting to experiment with the
server mode. This connection timeout feature is a precaution before we can do
large scale rollout. Some folks liked the concept of auto-cleanup of the
lldb-dap process, just to have the peace of mind that the memory issue isn't
caused by the debugger. Good to know about the memory monitor in DAP. That adds
more confidence.
3. Rename the option to "connection-timeout". I like this name a lot, esp.
because the other option is "--connection", so this has a nice synergy in the
names.
4. Catch that case of --connection-timeout is given while --connection isn't.
Print a warning.
5. Add tests.
--
(minor clarification:)
> I do think this should be configurable from the extension, like how folks can
> pick server mode there.
I wonder if you have any preference about whether this should be in this same
patch, or should be a separate follow-up. I have no strong opinion (shouldn't
be too much work), so I will just go with whichever you prefer.
https://github.com/llvm/llvm-project/pull/156803
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
