EugeneBi added inline comments.
================
Comment at: source/Plugins/ObjectFile/ELF/ELFHeader.cpp:108
+ if (ok) {
+ if (e_phnum_hdr == 0xFFFF)
+ e_phnum = section_zero.sh_info;
----------------
EugeneBi wrote:
> davidb wrote:
> > Would this make more sense to compare against a named constant ELF::PN_XNUM?
> Would be nice, but - where is it defined? I tried ELF::PN_XNUM, elf::PN_XNUM,
> PN_XNUM - compiler barks anyway.
>
OK, I see the other two are defined in Support/ELF.h, I'll put PN_XNUM there
then.
https://reviews.llvm.org/D29095
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
