davidb added inline comments.
================
Comment at: source/Plugins/ObjectFile/ELF/ELFHeader.cpp:108
+ if (ok) {
+ if (e_phnum_hdr == 0xFFFF)
+ e_phnum = section_zero.sh_info;
----------------
Would this make more sense to compare against a named constant ELF::PN_XNUM?
================
Comment at: source/Plugins/ObjectFile/ELF/ELFHeader.cpp:110
+ e_phnum = section_zero.sh_info;
+ if (e_shnum_hdr == 0)
+ e_shnum = section_zero.sh_size;
----------------
And this with SHN_UNDEF?
================
Comment at: source/Plugins/ObjectFile/ELF/ELFHeader.cpp:112
+ e_shnum = section_zero.sh_size;
+ if (e_shstrndx_hdr == 0xFFFF)
+ e_shstrndx = section_zero.sh_link;
----------------
and this with ELF::SHN_XINDEX.
https://reviews.llvm.org/D29095
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
