================
@@ -74,24 +74,48 @@ struct DemangledNameInfo {
return BasenameRange.second > BasenameRange.first;
}
+ /// Returns \c true if `BasenameRange` is empty.
+ bool isBasenameEmpty() const {
+ return BasenameRange.first == BasenameRange.second;
----------------
charles-zablit wrote:
I agree that since we are calling `!hasX && !isEmpty` everywhere, me might just
as well squash them. When doing so, the only problem I have noticed is that
some tests break, such as when demangling `Zinvalid` which technically has no
basename, but with this new implementation `hasBasename` returns true.
Overall, I still think it's best to collapse everything into one method like
you suggested 👍
https://github.com/llvm/llvm-project/pull/144731
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
