[Lldb-commits] [lldb] [lldb-dap] Minor visual changes to the modules UI (PR #139328)

[John Harrison via lldb-commits]

https://github.com/ashgti updated 
https://github.com/llvm/llvm-project/pull/139328

>From e2f9bc83de4ed72dd4025de195372813a034e0e7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere <jo...@devlieghere.com>
Date: Fri, 9 May 2025 14:31:30 -0700
Subject: [PATCH 1/2] [lldb-dap] Minor visual changes to the modules UI

Small assortment of changes to the modules UI after trying it out:

 - Print the load address as hexadecimal.
 - Remove spurious space before colon.
 - Drop "Module" prefix from tooltip title.
 - Capitalize bold list items.
---
 .../lldb-dap/src-ts/ui/modules-data-provider.ts  | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts 
b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
index 5af3d52e9870c..07b89b267b536 100644
--- a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
+++ b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
@@ -25,23 +25,25 @@ export class ModulesDataProvider
     }
 
     const tooltip = new vscode.MarkdownString();
-    tooltip.appendMarkdown(`# Module '${module.name}'\n\n`);
-    tooltip.appendMarkdown(`- **id** : ${module.id}\n`);
+    tooltip.appendMarkdown(`# ${module.name}\n\n`);
+    tooltip.appendMarkdown(`- **ID** : ${module.id}\n`);
     if (module.addressRange) {
-      tooltip.appendMarkdown(`- **load address** : ${module.addressRange}\n`);
+      tooltip.appendMarkdown(
+        `- **Load address**: 0x${Number(module.addressRange).toString(16)}\n`,
+      );
     }
     if (module.path) {
-      tooltip.appendMarkdown(`- **path** : ${module.path}\n`);
+      tooltip.appendMarkdown(`- **Path**: ${module.path}\n`);
     }
     if (module.version) {
-      tooltip.appendMarkdown(`- **version** : ${module.version}\n`);
+      tooltip.appendMarkdown(`- **Version**: ${module.version}\n`);
     }
     if (module.symbolStatus) {
-      tooltip.appendMarkdown(`- **symbol status** : ${module.symbolStatus}\n`);
+      tooltip.appendMarkdown(`- **Symbol status**: ${module.symbolStatus}\n`);
     }
     if (module.symbolFilePath) {
       tooltip.appendMarkdown(
-        `- **symbol file path** : ${module.symbolFilePath}\n`,
+        `- **Symbol file path**: ${module.symbolFilePath}\n`,
       );
     }
 

>From f8ade5ac2f75c6bd9da699e117ff477759333c5c Mon Sep 17 00:00:00 2001
From: John Harrison <harj...@google.com>
Date: Fri, 9 May 2025 16:04:11 -0700
Subject: [PATCH 2/2] Nit on whitespace.

---
 lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts 
b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
index 07b89b267b536..478c162de8878 100644
--- a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
+++ b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts
@@ -26,7 +26,7 @@ export class ModulesDataProvider
 
     const tooltip = new vscode.MarkdownString();
     tooltip.appendMarkdown(`# ${module.name}\n\n`);
-    tooltip.appendMarkdown(`- **ID** : ${module.id}\n`);
+    tooltip.appendMarkdown(`- **ID**: ${module.id}\n`);
     if (module.addressRange) {
       tooltip.appendMarkdown(
         `- **Load address**: 0x${Number(module.addressRange).toString(16)}\n`,

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits