llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) <details> <summary>Changes</summary> Small assortment of changes to the modules UI after trying it out: - Print the load address as hexadecimal. - Remove spurious space before colon. - Drop "Module" prefix from tooltip title. - Capitalize bold list items. <img width="817" alt="Screenshot 2025-05-09 at 2 34 10 PM" src="https://github.com/user-attachments/assets/5f902dae-87f2-4716-92f4-27e9dd3f6b37"; /> --- Full diff: https://github.com/llvm/llvm-project/pull/139328.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts (+9-7) ``````````diff diff --git a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts index 5af3d52e9870c..07b89b267b536 100644 --- a/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts +++ b/lldb/tools/lldb-dap/src-ts/ui/modules-data-provider.ts @@ -25,23 +25,25 @@ export class ModulesDataProvider } const tooltip = new vscode.MarkdownString(); - tooltip.appendMarkdown(`# Module '${module.name}'\n\n`); - tooltip.appendMarkdown(`- **id** : ${module.id}\n`); + tooltip.appendMarkdown(`# ${module.name}\n\n`); + tooltip.appendMarkdown(`- **ID** : ${module.id}\n`); if (module.addressRange) { - tooltip.appendMarkdown(`- **load address** : ${module.addressRange}\n`); + tooltip.appendMarkdown( + `- **Load address**: 0x${Number(module.addressRange).toString(16)}\n`, + ); } if (module.path) { - tooltip.appendMarkdown(`- **path** : ${module.path}\n`); + tooltip.appendMarkdown(`- **Path**: ${module.path}\n`); } if (module.version) { - tooltip.appendMarkdown(`- **version** : ${module.version}\n`); + tooltip.appendMarkdown(`- **Version**: ${module.version}\n`); } if (module.symbolStatus) { - tooltip.appendMarkdown(`- **symbol status** : ${module.symbolStatus}\n`); + tooltip.appendMarkdown(`- **Symbol status**: ${module.symbolStatus}\n`); } if (module.symbolFilePath) { tooltip.appendMarkdown( - `- **symbol file path** : ${module.symbolFilePath}\n`, + `- **Symbol file path**: ${module.symbolFilePath}\n`, ); } `````````` </details> https://github.com/llvm/llvm-project/pull/139328 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
