jimingham wrote: Note, the current stop locker is a `pthread_rwlock_t`. These locks according to the docs I could find are recursive for reading, but not recursive for writing. We need them to be recursive for reading because you want to do:
locker = process.GetStopLocker() process.GetThreadAtIndex() and the latter will also acquire need to acquire the stop locker's reader end. That should be okay since we would only expose the reader side, and we would always set the state in the locker on some lldb private thread before running any code. But we might want to make sure that you can't Continue the process while still holding the stop locker to keep from having the reader still in force when the writer needs to change the value. https://github.com/llvm/llvm-project/pull/134339 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
