llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) <details> <summary>Changes</summary> Previously, the test compared the JSON output to `setting_value` which was incorrect. Updated the assertion to validate against the correct list of paths `[path1, path2]` to ensure accurate test behavior. Ran the test on the local computer --- Full diff: https://github.com/llvm/llvm-project/pull/132410.diff 1 Files Affected: - (modified) lldb/test/API/commands/settings/TestSettings.py (+1-1) ``````````diff diff --git a/lldb/test/API/commands/settings/TestSettings.py b/lldb/test/API/commands/settings/TestSettings.py index 2a7c852fc916d..b9b66ea953971 100644 --- a/lldb/test/API/commands/settings/TestSettings.py +++ b/lldb/test/API/commands/settings/TestSettings.py @@ -1022,7 +1022,7 @@ def test_settings_api(self): path2 = os.path.join(self.getSourceDir(), "tmp2") self.runCmd("settings set %s '%s' '%s'" % (setting_path, path1, path2)) settings_json = self.get_setting_json(setting_path) - self.assertEqual(settings_json, setting_value) + self.assertEqual(settings_json, [path1, path2]) # Test OptionValueFormatEntity setting_value = """thread #${thread.index}{, name = \\'${thread.name}\\ `````````` </details> https://github.com/llvm/llvm-project/pull/132410 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
