joker-eph wrote: > The linked bug seems to explain it, I think?
I don't actually see a description of what is the problem to solve really. > It seems to be the usual "if something isn't/doesn't need to be declared in a > header, then it should be file-local static, so as to not conflict with other > local names in other files"? All of the files are `main()` file, not library files. Not clear to me what they would conflict with? > Right, though I think @joker-eph comment is that for lot of the MLIR changes, > these option variables are function local and they need not be changed to > static. This issue is only applicable to file scoped variables. That too :) https://github.com/llvm/llvm-project/pull/126243 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
