Michael137 wrote: Hmm one important difference here is that we would now not attach a name to the parameters that we create for free functions (we already don't do it for methods). I don't think having a name on the parameter is important for anything other than diagnostics of the expression evaluator. Hence the one test failure in `TestExprDiagnostics.py`:
We would now get: ``` note: candidate function not viable: requires 1 argument, but 2 were provided ``` instead of ``` note: candidate function not viable: requires single argument 'x', but 2 arguments were provided ``` I'm tempted to simply adjust the test-case and not worry about attaching names at all. But if other disagree, I guess we could plumb the parameter names from DWARF into `CreateParameterDeclarations`. https://github.com/llvm/llvm-project/pull/124279 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
