DavidSpickett wrote: This is a point of confusion, the LLVM project is set up to take the PR description, https://github.com/llvm/llvm-project/pull/112079#issue-2582537001 (the one you see on the page where this comment is also) as the commit message for the squashed commits.
As opposed to using the combination of the commits in the PR, or picking the last one, or whatever else GitHub allows. The merits of this - out of scope, but the point is that there is a chance to edit this description before it's used, but only the one merging gets that chance. So if you had the ability to merge you could do that and that's fine. But you don't so we need to know what it should be and the easiest way to do that is update the PR's description and all we have to do is click the button and accept what GitHub chooses. If you have a really good reason to keep the PR description as is (perhaps it includes a bunch of context for reviewers that might be useful for archaeology), then you can just write a new comment and we'll copy that. If this seems like I'm being overly verbose and maybe a bit insulting, that's not my intent, it's just a very tricky distinction to convey and I spent this morning also writing about it elsewhere :) . It's not perfect but it is what it is for the time being. https://github.com/llvm/llvm-project/pull/112079 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
