================
@@ -3265,18 +3275,25 @@ Status Process::PrivateResume() {
// (suspended/running/stepping). Threads should also check their resume
// signal in lldb::Thread::GetResumeSignal() to see if they are supposed to
// start back up with a signal.
- if (m_thread_list.WillResume()) {
+ RunDirection direction;
----------------
jimingham wrote:
I'm not concerned about performance, but rather that you do a bunch of work
(calling WillResume and the PreResumeActions) when you already know you are
going to discard the results because DoResume is going to return an error. It
always bugs me to do work in a situation where we know that work won't succeed.
It seems to me better to make this kind of decision as early as possible, it
just makes the code easier to reason about.
https://github.com/llvm/llvm-project/pull/112079
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
