oltolm wrote:

> I imagine that your change does make sense, but it's really not strictly tied 
> to lldb-dap. It's more generic and it's about what happens when the 
> expression evaluator is invoked from SBFrame when the process is not stopped, 
> right?

Yes the message "can't evaluate expressions when the process is running." 
appeared when process was not stopped.

> In any case, please reduce this PR to just the intended changes so that it's 
> easier to review.

Done.

> Also, feel free to commit directly to the repo formatting changes before 
> sending out the updated PR.

Sorry, I don't get this sentence. I just push my commits to this branch / PR.

https://github.com/llvm/llvm-project/pull/119103
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to