oltolm wrote:

> Thanks for not ignoring the formatter - but - please remove the formatting 
> changes in this case because it's obscuring the actual change. When changing 
> existing code like this, we often ignore the formatter for this reason.

Done.
 
> Also, I'm not sure this is any better. I guess that `br list` is evaluated as 
> an expression by default and that `'br list` is the escape character to say 
> "execute this as a command".
> 
> So if the target were running, `expr br list` would indeed fail with `can't 
> evaluate expressions when the process is running.`. As it is - running. Are 
> you saying that it does this even when stopped?

Yes, this message appears even when stopped. I know that "sbframe object is not 
valid." is not helpful, but at least it is not misleading. I could improve it 
in this PR if you have any suggestions or leave it for another PR.

https://github.com/llvm/llvm-project/pull/119103
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to