tfiala added a comment.
Looks like a nice start. Thanks for pulling this together, Chris!
================
Comment at: lit/CMakeLists.txt:14
@@ -13,1 +13,3 @@
+option(LLDB_TEST_CLANG "Use in-tree clang when testing lldb" Off)
+
----------------
The macOS bots (and all the Swift ones) build with in-tree clang. I'm glad to
have this option.
================
Comment at: lit/CMakeLists.txt:26
@@ -23,1 +25,3 @@
+ FileCheck
+ debugserver
LLDBUnitTests
----------------
Not entirely sure what exactly this is checking, but for non-Apple platforms
(and maybe Apple in the future), we'll be using an lldb-server binary rather
than debugserver. Anything we need to do here to handle that?
================
Comment at: lit/lit.cfg:190
@@ -126,1 +189,3 @@
+elif re.match(r'cl', cc):
+ config.available_features.add("compiler-msvc")
----------------
As we discussed earlier, it'll be helpful to be able to parse out the compiler
versions so we can do some kind of conditional check on specific version or
version ranges for known bugs (or features).
https://reviews.llvm.org/D24591
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
