> On Aug 11, 2016, at 4:00 PM, Enrico Granata <egran...@apple.com> wrote: > > >> On Aug 11, 2016, at 3:55 PM, Jim Ingham via lldb-commits >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: >> >> jingham added a comment. >> >> The patch seems correct to me. >> >> I don't have a strong opinion about std::vector vrs. SmallVector. These are >> temporary objects, so the size of the container doesn't matter, and I doubt >> this code is hot enough in normal lldb sessions that the difference between >> in performance between the two will matter. Maybe the SmallVector data >> formatter (llvm/utils/lldbDataFormatters.py) works, or if it doesn't we >> should fix it? > > IIRC, Argyrios wrote those formatters a few years ago, so +Argyrios to > comment on whether it's expected to work
I haven’t touch those for a long time, I’m not sure if they are still working. > >> >> >> https://reviews.llvm.org/D23406 <https://reviews.llvm.org/D23406> >> >> >> >> _______________________________________________ >> lldb-commits mailing list >> lldb-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > > > Thanks, > - Enrico > 📩 egranata@.com ☎️ 27683 >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
