jingham added a comment. The patch seems correct to me.
I don't have a strong opinion about std::vector vrs. SmallVector. These are temporary objects, so the size of the container doesn't matter, and I doubt this code is hot enough in normal lldb sessions that the difference between in performance between the two will matter. Maybe the SmallVector data formatter (llvm/utils/lldbDataFormatters.py) works, or if it doesn't we should fix it? https://reviews.llvm.org/D23406 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
