labath added a comment.

You raised good points here, Luke.

I've thought about the quoting issue, but as you have already noticed there is 
no way to pass arguments containing quotes to adb correctly. Thinking about it 
more, what we could do is detect this situation (look for `'` in the file name) 
and abort the whole process even before issuing the "adb shell" command.

As for the return value, this should not be a big problem, as further down the 
line we will discover that this is not a real ELF file and ignore it, but 
perhaps we could help here by searching for the file name in the first 1K bytes 
of the result, and ignoring the file if we find it?

Oleksiy, what do you think?


http://reviews.llvm.org/D22081



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to